-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backoff jitter #10486
Add backoff jitter #10486
Conversation
Signed-off-by: Ajinkya Bhandare <112012663+ajinkyavbhandare@users.noreply.github.com>
Signed-off-by: Ajinkya Bhandare <112012663+ajinkyavbhandare@users.noreply.github.com>
Documentation preview for 33fcf70 will be available here when this CircleCI job completes successfully. More info
|
Signed-off-by: Ajinkya Bhandare <112012663+ajinkyavbhandare@users.noreply.github.com>
@ajinkyavbhandare why you closed it? |
where is the new PR? |
@ajinkyavbhandare what's the difference? |
we can keep working on this one. |
let me push a commit. |
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
max_retries = max_retries or MLFLOW_HTTP_REQUEST_MAX_RETRIES.get() | ||
backoff_factor = backoff_factor or MLFLOW_HTTP_REQUEST_BACKOFF_FACTOR.get() | ||
timeout = timeout or MLFLOW_HTTP_REQUEST_TIMEOUT.get() | ||
max_retries = MLFLOW_HTTP_REQUEST_MAX_RETRIES.get() if max_retries is None else max_retries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the original code, max_retries = 0
defaults to MLFLOW_HTTP_REQUEST_MAX_RETRIES.get()
but it should not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Manually tested using this toy fastapi app: from fastapi import FastAPI, HTTPException, status
app = FastAPI()
counter = 0
@app.get("/test")
def test():
global counter
counter += 1
if counter < 3:
raise HTTPException(
status_code=status.HTTP_502_BAD_GATEWAY,
detail="Service unavailable",
)
else:
# Reset counter
counter = 0
return {"counter": counter}
# Command to run this app using uvicorn:
# uvicorn app:app --reload --port 8000 |
@ajinkyavbhandare Thanks for the contribution! |
@harupy Thank you , I'm grateful for the opportunity to be a part of this project. |
Signed-off-by: Ajinkya Bhandare <112012663+ajinkyavbhandare@users.noreply.github.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: swathi <konakanchi.swathi@gmail.com>
🛠 DevTools 🛠
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
Resolve #10482
What changes are proposed in this pull request?
This PR adds a backoff jitter to HTTP requests in MLflow. This is achieved by introducing a new environment variable
MLFLOW_HTTP_REQUEST_BACKOFF_JITTER
and using this variable when making HTTP requests.How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Yes. This change introduces a backoff jitter to HTTP requests, which can help improve the efficiency and reliability of the requests.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/gateway
: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes